[24195] Fix ReturnCode comparisons - #146
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 60.26% 60.30% +0.03%
==========================================
Files 65 65
Lines 1933 1945 +12
Branches 552 552
==========================================
+ Hits 1165 1173 +8
- Misses 446 450 +4
Partials 322 322 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emiliocuestaf
force-pushed
the
bugfix/retcode-comparison
branch
from
January 7, 2026 15:49
e588384 to
87e9962
Compare
emiliocuestaf
changed the title
emiliocuestaf
requested review from
richiprosima
and removed request for
juanlofer-eprosima
February 19, 2026 08:58
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Danipiza
force-pushed
the
bugfix/retcode-comparison
branch
from
February 20, 2026 12:25
bcee9a9 to
8958885
Compare
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Danipiza
requested review from
raulojeda22
and removed request for
richiprosima
February 27, 2026 07:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Adding comparison operator useful in switch or if else code blocks. Currently, the comparisons of the type
ReturnCode A == ReturnCode::RETCODE_X (This is actually of type ReturnCodeValue)are implicitly calling the constructor
ReturnCode::ReturnCode(const fastdds::dds::ReturnCode_t& value)for the right operand of the equality.
This can lead to issues since that constructor is not designed for variables of the type ReturnCodeValue but it is still called since both enums fall back to integers.
A new constructor from type ReturnCodeValue has been added to mitigate this issue
These are the artifacts generated using this patch on eprosimaCI:
Note they all use the suffix "_devutils_retcode_patch"
These are the CI's of the tools that depend on DevUtils running over those artifacts
DDSPipe: https://github.com/eProsima/DDS-Pipe/actions/runs/20878338498 (OK)DDSRouter: https://github.com/eProsima/DDS-Router/actions/runs/20883380087 (OK)Fast DDS Spy: https://github.com/eProsima/Fast-DDS-spy/actions/runs/20917933468 (OK)Fast DDS Statistics Backend: https://github.com/eProsima/Fast-DDS-statistics-backend/actions/runs/20877556296 (OK, docs have nothing to do with this PR)Fast DDS Monitor: - does not have tests -Fast DDS Record and Replay: https://github.com/eProsima/DDS-Record-Replay/actions/runs/20883351480 (OK, the error is unrelated)NEW TESTS: